Ticket #11 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

Invalid pidfile content causes sisyphus to fail

Reported by: zgoda Owned by: walter
Priority: major Milestone:
Component: xist Keywords:
Cc:

Description

In the case of system failure (such as storage failure) pidfile may exist but be empty. sisyphus.Job does not handle this situation properly, assuming the file contains numeric content, see http://flloss.livinglogic.de/browser/livinglogic.python.xist/src/ll/sisyphus.py#L299. In my opinion a call to int(file.read()) should be guarded against ValueError and pidfile should be treated as invalid in case of such error, like:

try:
    pid = int(file.read())
except ValueError:
    self.__writepid()
    self.logProgress("ignoring bogus pid file %s (invalid content)" % self.pidfilename)

Change History

comment:1 Changed 10 years ago by walter

  • status changed from new to closed
  • resolution set to fixed

This problem should be fixed in release 3.6.6. Thanks for the bug report.

Note: See TracTickets for help on using tickets.